tests: Prevent unittest --buffer
from crashing
#620
Merged
+6
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, if certain tests were failing in certain ways, then running
python -m unittest --buffer
would cause anAttributeError
in theunittest
module itself.Here’s what
unittest
does when you use the--buffer
argument:sys.stdout
andsys.stderr
toStringIO
s.getvalue()
onsys.stdout
andsys.stderr
to get data from itsStringIO
s.tests/test_cli.py
has its ownRunContext
class that does something similar. Before this change, here’s what could happen:unittest
setssys.stdout
andsys.stderr
toStringIO
s.unittest
runs a test that usesRunContext
.A
RunContext
gets entered. It setssys.stdout
andsys.stderr
to its ownStringIO
s.The
RunContext
gets exited. It setssys.stdout
andsys.stderr
tosys.__stdout__
andsys.__stderr__
.The test fails.
unittest
assumes thatsys.stdout
is still set to one of itsStringIO
s, and runssys.stdout.getvalue()
.unittest
crashes with this error: